Hi Collin, > This patch adds the reminders to use AC_PROG_CC macro instead of > the obsolete AC_PROG_CC_STDC or AC_PROG_CC_C99. > > This change is pretty small so it seemed like a good place to remove > the exit() from GLImport.execute().
Nice! Thanks, patch applied. > The only spooky line is: > > sp.call(['rm', '-rf', self.config['tempdir']], shell=False) > > but this seems generally safe to me. The GLConfig's tempdir is set > unconditionally before anything else is done in GLConfig.__init__() > using mkdtemp(). Since a GLConfig object is always created in > GLImport.__init__() it seems that self.config['tempdir'] will always > be a safe directory to remove in '/tmp', or similar. That is the hope > atleast. Since you say "spooky", I reviewed it as well. And like you, I come to the conclusion that it's safe, and that future maintenance is unlikely to assign '' or '/' to self.config['tempdir']. So, no need to add an extra safety check, I would say. Bruno
