Collin Funk wrote:
> See this decade old typo:
> 
> diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py
> index d417137df6..2434e5f506 100644
> --- a/pygnulib/GLImport.py
> +++ b/pygnulib/GLImport.py
> @@ -1393,7 +1393,7 @@ AC_DEFUN([%s_FILE_LIST], [\n''' % macro_prefix
>              # Treat gnulib-comp.m4 like an added file, even if it already 
> existed.
>              filetable['added'] += [joinpath(m4base, 'gnulib-comp.m4')]
>              filetable['added'] = sorted(set(filetable['added']))
> -            filetable['removed'] = sorted(set(filetable['added']))
> +            filetable['removed'] = sorted(set(filetable['removed']))

Oh, indeed. If filetable['added'] and filetable['removed'] are the same,
no wonder that you are seeing nonsense in the .gitignore files...

> Then when creating the list of "dir|op|file" gnulib-tool.sh pipes it
> into this:
> 
> LC_ALL=C sort -t'|' -k1,1 > "$tmp"/fileset-changes
> 
> but gnulib-tool.py doesn't do any sorting. Hopefully I am on the
> correct track now atleast.

The sorting is probably relevant for the added files (since they get added
at the end of the .gitignore file), but redundant for the removed files.

Bruno




Reply via email to