On 4/28/24 2:52 AM, Bruno Haible wrote: > Thanks! OK to push in 1 or 2 days.
Sounds good. >> Though, the correct way to fix this would be making instance variables >> local when they are only used in one function. > > I agree that this kind of doing side effects on a GLConfig object that > is already held by another object is not super maintainable. Yeah, there are many things I dislike about that class. I'll probably have a look at *slowly* cleaning it up eventually. There is a bunch of dead code in there if I remember correctly. > However, this is not the only call to setLibTests. There is another one > at GLTestDir.py:392. And there is a call to setAuxDir in GLTestDir.py:401. > It seems that a conversion to use instance variables or local variables > would be quite intrusive. I'm not sure this refactoring would be worth it. Good point. I'll probably have to double check those too. Collin
