Hi Collin,
> Can I apply the attached patched?
Yes, now it is OK to push.
> Also, last night when fixing the quoting issue I was thinking if
> gnulib-tool.py should quit on unsupported platforms (native Windows).
Yes, this is reasonable, since we already determined that our
unsupported platforms are unsupported for a good reason: no adequate
support for running shell scripts, autoconf, automake.
However, you need to define "native Windows" here.
- A Cygwin (or MSYS2) installation combined with a Cygwin-built Python
will work, even without modifications in the subprocess.* calls.
- A Cygwin (or MSYS2) installation combined with a native Python
will need modifications in the subprocess.* calls, namely to insert a
first argument "sh" in many places. (I wouldn't use shell=True in
this case, unless we can guarantee that it will call "sh", not "cmd".)
Maybe it will also need other modifications, I don't know. Hopefully
not.
> On Cygwin and MSYS2 'os.name' seems to be 'posix' [1]. Should we check
> that before running?
os.name == 'nt' would also be valid, if "sh" can be found.
Bruno
