Hi Bruno, On 5/8/24 12:25 AM, Bruno Haible wrote: >> I noticed Gnulib changed most of the *_WRAPV to the ckd_* variants at >> some point. Is there a reason that INT_MULTIPLY_OK is still used in >> base32 and base64 or can I apply the following patch? > > No particular reason. The patch is OK to push.
Done, thanks. >> It looks like the module description were missing 'intprops' in the >> depends on these modules too. I guess everyone that used it had it in >> their module list or as a transitive dependency. > > Such a blatant module dependency omission should be detectable with > $ ./gnulib-tool --test --single-configure base32 > $ ./gnulib-tool --test --single-configure base64 Thanks for the info! You would think that I know how to use gnulib-tool after working on gnulib-tool.py but that is clearly not the case. :) > With .sh, both fail. With .py, both succeed. Looks like a bug in > gnulib-tool.py: When the 'make' or 'make check' step fails, the entire > command should fail. I see what you mean. I'll have a look at fixing that right now. Collin
