Hi Paul, > * tests/tst-stdc_trailing_zeros.c: > New files, copied verbatim from glibc.
The file name prefix 'tst-' bothers me a bit, because * It is inconsistent with the prefix 'test-' that we've been using since 2003. * It causes more typing, because the autocompletion t<TAB> → test no longer works (both in the source directory and in a builddir's gltests/ directory). I would propose to rename the files to 'test-*' in Gnulib. They are not likely to be modified frequently in glibc, therefore the gnulib <--> glibc merge effort is likely zero. And annotate the mapping in config/srclist.txt accordingly. If you have objections to that, I would instead - move the tst-* files to a subdirectory, say from-glibc/, - change the module descriptions so that tests/from-glibc/tst-stdc_trailing_zeros.c is compiled to an executable named ${tests_prefix}/test-stdc_trailing_zeros${EXEEXT}. So that the autocompletion again works. Bruno