Hi Collin, > Indirectly this also fixes two issues. The first is the same issue as > yesterdays patch. Variables with a trailing comment, e.g. > > lib_SOURCES += file.c file.h # comment > > are not matched. As far as I can tell none of the module descriptions > have this comment style but gnulib-tool.sh handles it (line 3453-3466). > So gnulib-tool.py should too.
Thanks! Yes, gnulib-tool should handle this. The variable mentioned_files in pygnulib/GLModuleSystem.py line 599 was a set and is now a list. Is the expression lib_files.difference(mentioned_files) therefore being evaluated more slowly (as O(n²) where it was O(n) before)? That is, does Python iterate through mentioned_files for each element of lib_files, or does Python convert the argument mentioned_files internally to a set first? Bruno
