* top/maint.mk (_gl_tight_scope): Sort $(SOURCES), to remove
duplicates and thereby avoid unnecessary work.  Found when testing
this on GNU diffutils.
---
 ChangeLog    | 7 +++++++
 top/maint.mk | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 3d34109399..dc37db37f1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2024-06-11  Paul Eggert  <egg...@cs.ucla.edu>
+
+       maint: avoid duplicate tight-scope work
+       * top/maint.mk (_gl_tight_scope): Sort $(SOURCES), to remove
+       duplicates and thereby avoid unnecessary work.  Found when testing
+       this on GNU diffutils.
+
 2024-06-09  Collin Funk  <collin.fu...@gmail.com>
 
        gnulib-tool.py: Handle absolute path checks consistently.
diff --git a/top/maint.mk b/top/maint.mk
index c20059fbae..2f35253fb7 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1888,7 +1888,7 @@ _gl_tight_scope: $(bin_PROGRAMS)
        for sig in 1 2 3 13 15; do                                      \
          eval "trap 'v=`expr $$sig + 128`; (exit $$v); exit $$v' $$sig"; \
        done;                                                           \
-       src=`for f in $(SOURCES); do                                    \
+       src=`for f in $(sort $(SOURCES)); do                            \
               test -f $$f && d= || d=$(srcdir)/; echo $$d$$f; done`;   \
        hdr=`for f in $(_gl_TS_headers); do                             \
               test -f $$f && d= || d=$(srcdir)/; echo $$d$$f; done`;   \
-- 
2.43.0


Reply via email to