Markus Mützel wrote:
> With the same reasoning as for ftello.c, should this also be changed in
> fseeko.c?
>
> diff --git a/lib/fseeko.c b/lib/fseeko.c
> index 2c3b053a3b..9d003208ba 100644
> --- a/lib/fseeko.c
> +++ b/lib/fseeko.c
> @@ -31,7 +31,10 @@ fseeko (FILE *fp, off_t offset, int whence)
> # undef fseek
> # define fseeko fseek
> #endif
> -#if _GL_WINDOWS_64_BIT_OFF_T
> +#if (defined _WIN32 && !defined __CYGWIN__) \
> + /* We need to test _FILE_OFFSET_BITS for mingw-w64 */ \
> + /* and _GL_WINDOWS_64_BIT_OFF_T for MSVC. */ \
> + && (_FILE_OFFSET_BITS == 64 || _GL_WINDOWS_64_BIT_OFF_T)
> # undef fseeko
> # if HAVE__FSEEKI64 && HAVE_DECL__FSEEKI64 /* msvc, mingw since msvcrt8.0,
> mingw64 */
> # define fseeko _fseeki64
No, this is not needed. In a testdir of the modules fseeko, ftello, fsync,
on mingw:
- we have REPLACE_FSEEKO=1, hence fseeko.c gets compiled, and it uses
the mingw fseeko function,
- the two new unit tests pass.
- Apparently the mingw fseeko already supports the 64-bit argument fine.
Bruno
