Paul Eggert wrote on 2024-09-30:
> * m4/acl.m4 (gl_FUNC_ACL_ARG): Add --without-libsmack option.
> (gl_FILE_HAS_ACL): Check for libsmack, selinux.

There is a mistake here:
- The only possible values of with_libsmack are empty and 'maybe'.
- Use of --with-libsmack and --without-libsmack has no effect.

With this patch:
- The possible values of with_libsmack are 'yes', 'no', 'maybe'.
- Use of --without-libsmack removes the test for <sys/smack.h>.


2025-01-26  Bruno Haible  <[email protected]>

        file-has-acl: Fix --with-libsmack option handling.
        * m4/acl.m4 (gl_FUNC_ACL_ARG): Add missing comma between macro
        arguments.

diff --git a/m4/acl.m4 b/m4/acl.m4
index c9cb6dd09e..7e4b0e354d 100644
--- a/m4/acl.m4
+++ b/m4/acl.m4
@@ -1,5 +1,5 @@
 # acl.m4
-# serial 34
+# serial 35
 dnl Copyright (C) 2002, 2004-2025 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -18,7 +18,7 @@ AC_DEFUN([gl_FUNC_ACL_ARG]
     , [enable_acl=auto])
   AC_ARG_WITH([libsmack],
     [AS_HELP_STRING([--without-libsmack],
-       [do not use libsmack, even on systems that have it])]
+       [do not use libsmack, even on systems that have it])],
     [], [with_libsmack=maybe])
 ])
 




Reply via email to