On Tue, Jun 10, 2025 at 07:50:10PM -0400, Paul Moore wrote: > On Fri, Jun 6, 2025 at 1:39 AM Collin Funk <[email protected]> wrote: > > Paul Moore <[email protected]> writes: > > >> <[email protected]> wrote: > > >> > > > >> > commit 8b0ba61df5a1 ("fs/xattr.c: fix simple_xattr_list to always > > >> > include security.* xattrs") failed to reset err after the call to > > >> > security_inode_listsecurity(), which returns the length of the > > >> > returned xattr name. This results in simple_xattr_list() incorrectly > > >> > returning this length even if a POSIX acl is also set on the inode. > > >> > > > >> > Reported-by: Collin Funk <[email protected]> > > >> > Closes: https://lore.kernel.org/selinux/[email protected]/ > > >> > Reported-by: Paul Eggert <[email protected]> > > >> > Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2369561 > > >> > Fixes: 8b0ba61df5a1 ("fs/xattr.c: fix simple_xattr_list to always > > >> > include security.* xattrs") > > >> > > > >> > Signed-off-by: Stephen Smalley <[email protected]> > > >> > --- > > >> > fs/xattr.c | 1 + > > >> > 1 file changed, 1 insertion(+) > > >> > > >> Reviewed-by: Paul Moore <[email protected]> > > > > > > Resending this as it appears that Stephen's original posting had a > > > typo in the VFS mailing list. The original post can be found in the > > > SELinux archives: > > > > > > https://lore.kernel.org/selinux/[email protected]/ > > > > Hi, responding to this message since it has the correct lists. > > > > I just booted into a kernel with this patch applied and confirm that it > > fixes the Gnulib tests that were failing. > > > > Reviewed-by: Collin Funk <[email protected]> > > Tested-by: Collin Funk <[email protected]> > > > > Thanks for the fix. > > Al, Christian, are either of you going to pick up this fix to send to > Linus? If not, any objection if I send this up?
It's been in vfs.fixes for some time already and it'll go out with the first round of post -rc1 fixes this week.
