Hi Bruno, Bruno Haible <[email protected]> writes:
>> I pushed the attached V2 patches of these, which I believe addresses all >> the points brought up in review. I tested them all again with GCC 4.8.5 >> and GCC 15, so that the builtin and non-builtin paths were checked. > > Thanks! > > In the *.texi files, please use @mindex, like in the other *.texi files. > This ensures the module shows up in the index. Oh, right. I have forgotten about that a few times now. I'll have a look at adding a syntax-check rule for it. > tests/test-stdc_rotate_right.c line 32 has a whitespace problem. Thanks, I pushed the attached patches which fix those issues. Collin
>From b3d72fbce1c11bb62f6f50e175e0334be7a1bce1 Mon Sep 17 00:00:00 2001 Message-ID: <b3d72fbce1c11bb62f6f50e175e0334be7a1bce1.1773639022.git.collin.fu...@gmail.com> From: Collin Funk <[email protected]> Date: Sun, 15 Mar 2026 22:27:18 -0700 Subject: [PATCH 1/2] doc: add missing module indexes. Reported by Bruno Haible in <https://lists.gnu.org/r/bug-gnulib/2026-03/msg00124.html>. * doc/posix-functions/stdc_rotate_left.texi: Add missing module index. * doc/posix-functions/stdc_rotate_right.texi: Likewise. --- ChangeLog | 6 ++++++ doc/posix-functions/stdc_rotate_left.texi | 1 + doc/posix-functions/stdc_rotate_right.texi | 1 + 3 files changed, 8 insertions(+) diff --git a/ChangeLog b/ChangeLog index c1c6051875..ff09bde270 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2026-03-15 Collin Funk <[email protected]> + doc: add missing module indexes. + Reported by Bruno Haible in + <https://lists.gnu.org/r/bug-gnulib/2026-03/msg00124.html>. + * doc/posix-functions/stdc_rotate_left.texi: Add missing module index. + * doc/posix-functions/stdc_rotate_right.texi: Likewise. + stdc_rotate_right: Add tests. * modules/stdc_rotate_right-tests: New file. * tests/test-stdc_rotate_right.c: Likewise. diff --git a/doc/posix-functions/stdc_rotate_left.texi b/doc/posix-functions/stdc_rotate_left.texi index 2e4c89c1b2..fea4184a0b 100644 --- a/doc/posix-functions/stdc_rotate_left.texi +++ b/doc/posix-functions/stdc_rotate_left.texi @@ -13,6 +13,7 @@ @node stdc_rotate_left section 7.18.17. Gnulib module: stdc_rotate_left +@mindex stdc_rotate_left Portability problems fixed by Gnulib: @itemize diff --git a/doc/posix-functions/stdc_rotate_right.texi b/doc/posix-functions/stdc_rotate_right.texi index 78c08ce56a..760a8d7332 100644 --- a/doc/posix-functions/stdc_rotate_right.texi +++ b/doc/posix-functions/stdc_rotate_right.texi @@ -13,6 +13,7 @@ @node stdc_rotate_right section 7.18.18. Gnulib module: stdc_rotate_right +@mindex stdc_rotate_right Portability problems fixed by Gnulib: @itemize -- 2.53.0
>From 592715d1d51e1b8149e1ad16112b2ecd54acb2cc Mon Sep 17 00:00:00 2001 Message-ID: <592715d1d51e1b8149e1ad16112b2ecd54acb2cc.1773639022.git.collin.fu...@gmail.com> In-Reply-To: <b3d72fbce1c11bb62f6f50e175e0334be7a1bce1.1773639022.git.collin.fu...@gmail.com> References: <b3d72fbce1c11bb62f6f50e175e0334be7a1bce1.1773639022.git.collin.fu...@gmail.com> From: Collin Funk <[email protected]> Date: Sun, 15 Mar 2026 22:29:25 -0700 Subject: [PATCH 2/2] test-stdc_rotate_right tests: Fix whitespace. * tests/test-stdc_rotate_right.c (TEST_CASE): Remove extra space character. --- ChangeLog | 4 ++++ tests/test-stdc_rotate_right.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index ff09bde270..df86248681 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2026-03-15 Collin Funk <[email protected]> + test-stdc_rotate_right tests: Fix whitespace. + * tests/test-stdc_rotate_right.c (TEST_CASE): Remove extra space + character. + doc: add missing module indexes. Reported by Bruno Haible in <https://lists.gnu.org/r/bug-gnulib/2026-03/msg00124.html>. diff --git a/tests/test-stdc_rotate_right.c b/tests/test-stdc_rotate_right.c index c424d75cc2..e453223b6d 100644 --- a/tests/test-stdc_rotate_right.c +++ b/tests/test-stdc_rotate_right.c @@ -29,7 +29,7 @@ type v = value; \ type e = expect; \ ASSERT (function (v, shift) == expect); \ - ASSERT (stdc_rotate_right (v, shift) == expect); \ + ASSERT (stdc_rotate_right (v, shift) == expect); \ } \ while (false) -- 2.53.0
