Hi Collin, > When running 'make check' I saw this error: > > modules/stdio-windows > use AC_CHECK_FUNCS_ONCE, not AC_CHECK_FUNCS in modules/ > make: *** [Makefile:35: sc_prefer_ac_check_funcs_once] Error 1 > > Is there any reason for stdio-windows should be treated differently?
That's not relevant; it's only a syntax-check rule. What is relevant is that there are 3 occurrences of the same AC_CHECK_FUNCS invocation. Which can make a 'configure' script do more checking than needed: $ fgrep -r 'AC_CHECK_FUNCS([vasprintf])' . ./modules/stdio-windows:AC_CHECK_FUNCS([vasprintf]) ./m4/vasprintf.m4: AC_CHECK_FUNCS([vasprintf]) ./m4/vasprintf-posix.m4: AC_CHECK_FUNCS([vasprintf]) > I assume not so I have attached the patch that fixes it, but I don't know > much about this module so figured I should ask before pushing. You are welcome to change all 3 occurrences to use AC_CHECK_FUNCS_ONCE. Bruno
