Paul Eggert wrote:
> > lib/mbiter-aux.c:32:         to U+0100.  (See libiconv/tests/*.TXT for all 
> > the mapping tables.)
> 
> I have also run into that irritating clang warning.

If it was only a clang warning, I would not care much, because clang has
a lot of annoying warnings, such as about
  10 ^ 2
where it suggests that you may have meant pow(10,2).

But gcc produces the same warning with -Wall:

  ../../gllib/mbiter-aux.c:32:41: warning: ‘/*’ within comment [-Wcomment]

> Perhaps we should use // comments there....

// is C++ style, IMO. I sometimes use full-width Unicode characters as a
workaround, but that does not work here with copy&paste into a command line...


2026-07-21  Bruno Haible  <[email protected]>

        mbiter-aux: Avoid gcc -Wcomment warning.
        Reported by G. Branden Robinson in
        <https://lists.gnu.org/archive/html/bug-gnulib/2026-07/msg00127.html>.
        * lib/mbiter-aux.c (mbiter_is_utf8): Tweak comment.

diff --git a/lib/mbiter-aux.c b/lib/mbiter-aux.c
index 125e02ebe3..c534b32c44 100644
--- a/lib/mbiter-aux.c
+++ b/lib/mbiter-aux.c
@@ -29,7 +29,7 @@ mbiter_is_utf8 (int *cache)
   if (*cache < 0)
     {
       /* UTF-8 is the only encoding in use which maps the bytes 0xC4 0x80
-         to U+0100.  (See libiconv/tests/*.TXT for all the mapping tables.)
+         to U+0100.  (See libiconv/tests/?*.TXT for all the mapping tables.)
          We can assume that in this case, the char32_t encoding is Unicode
          (not platform-dependent like for other locale encodings).  */
       mbstate_t state; mbszero (&state);




Reply via email to