URL: <https://savannah.gnu.org/bugs/?55690>
Summary: Black images when linked with libicns; smalles icon is always loaded Project: GNUstep Submitted by: yavor Submitted on: Mon 11 Feb 2019 12:13:38 AM EET Category: Gui/AppKit Severity: 3 - Normal Item Group: Bug Status: None Privacy: Public Assigned to: None Open/Closed: Open Discussion Lock: Any _______________________________________________________ Details: With libicns/0.8.1, all images derived from .icns files are black. This happens because icns_get_image32_with_mask_from_family from libicns is able to handle more formats unlike the implementation in NSBitmapImageRep+ICNS.m which caters only for the 32-bit format. IOW, when loading TalkSoup.icns, the array contains 4 elements with the built-in implementation but 7 elements when linked with external libicns. Another issue (regardless of the libicns implementation used) is that always the smallest icon is loaded as the app icon; it happens to be the first in the array as the .icns file is processed sequentially. I guess this is because the first one is tried and it passes as "best representation"... However it looks really ugly for apps that use .icns files for the app icon (TalkSoup, TextEdit, Lynkeos, FreeCell). Attached is a patch that solves both of these problems, albeit in a clumsy way. _______________________________________________________ File Attachments: ------------------------------------------------------- Date: Mon 11 Feb 2019 12:13:38 AM EET Name: 0001-Fix-image-extraction-with-libicns-place-48x48-icon-a.patch Size: 3KiB By: yavor <http://savannah.gnu.org/bugs/download.php?file_id=46231> _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?55690> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ _______________________________________________ Bug-gnustep mailing list Bug-gnustep@gnu.org https://lists.gnu.org/mailman/listinfo/bug-gnustep