Charles Levert wrote:
This was trivial to modify after all.
Ok to apply?
Not sure. If we're happy with the change in behaviour then yes, your patch
looks good, but I have a feeling that such a change could be seen as a major
regression by many people.
From what you have found in the code, it appears that the behaviour was
changed such that "directories=read" behaves the same as "directories=skip".
(I haven't looked at the surrounding code yet, so I'm not sure.) I can't yet
imagine why this was done, but I think we have a duty (to the users) to try to
find out. Maybe the CVS archives or possibly the mail archives can help.
I'll see if I can investigate soon.
- Julian
[...]
--- grep/src/grep.c 24 Aug 2005 07:28:29 -0000 1.113
+++ grep/src/grep.c 3 Nov 2005 03:49:49 -0000
@@ -1065,8 +1065,7 @@ grep (int fd, char const *file, struct s
if (! fillbuf (save, stats))
{
- if (! is_EISDIR (errno, file))
- suppressible_error (filename, errno);
+ suppressible_error (filename, errno);
return 0;
}
[...]
