Hi Jim. > I've made the above two changes with a commit in your name.
Great, thanks. > However, I'll pass on the other changes. > > > +#ifdef HAVE_CONFIG_H > > #include <config.h> > > +#endif I can remove that from dfa.c, no big deal. > > #include <assert.h> > > #include <ctype.h> > > #include <stdio.h> > > + > > +#ifndef VMS > > #include <sys/types.h> > > +#else > > #include <stddef.h> > > +#endif > > Both sys/types.h and stddef.h are guaranteed to be available > and usable for grep, since it uses gnulib, so we might as well > include them unconditionally. > > Besides, I suspect no one uses VMS anymore. Not so. I have people using VMS. I would really like to continue to be able to support them. > > #include <stdlib.h> > > #include <limits.h> > > #include <string.h> > > -#include <locale.h> > > +#if HAVE_SETLOCALE > > +# include <locale.h> > > +#endif > > Likewise. Here too for VMS, as well as for non-cygwin Windows. > > +#ifndef DEBUG /* use the same approach as regex.c */ > > +#undef assert > > +#define assert(e) > > +#endif /* DEBUG */ > > There is only one assertion, and it's trivial, > so I prefer to leave it enabled and to omit those lines. > Compile with NDEBUG if you want to turn off that sole assertion. I'll pull that out. The main issues are the above two; can we meet in the middle? Thanks, Arnold
