On 06/21/2011 08:21 AM, Jim Meyering wrote: > I suppose I should make them consistent, but it really doesn't matter, > since each is invoked via "$(SHELL) test_name". > Back when scripts were invoked via ./test_name it used to matter.
You are right that when invoked by 'make check', it doesn't matter, thanks to our use of $(SHELL). But the tests seem independently useful - if they have a chance of running in isolation without having any of the 'make check' TESTS_ENVIRONMENT, then they should probably be all executable so that someone could do 'cd tests && ./test-foo' rather than 'make -C tests check TESTS=test-foo' to rerun just a single test. -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
