A few months ago, "make syntax-check" would complain if any string that
was subject to localisation started with an upper-case character.
Almost all messages in Grep conform to this standard. However,
"make syntax-check" no longer complains about two cases in the current
master (dfa.c, function lex ()):
dfaerror (_("Invalid content of \\{\\}"));
dfaerror (_("Regular expression too big"));
I don't know if this constraint is being relaxed, or if the check has
changed somehow. (Is syntax-check provided via gnulib?)
Attached is a simple patch that converts the two error strings above to
have a lower-case first character. This may be useful to help maintain
consistent message formatting.
cheers,
behoffski (Brenton Hoff)
Programmer, Grouse Software
>From 5ba304cbbdf89e736dfdd087613ba64e6dc32f50 Mon Sep 17 00:00:00 2001
From: behoffski <[email protected]>
Date: Mon, 12 May 2014 12:58:56 +0930
Subject: [PATCH] dfa.c (lex): Remove first-letter capitalisation of two
dfaerror message strings.
---
src/dfa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/dfa.c b/src/dfa.c
index 3c9cb75..2408278 100644
--- a/src/dfa.c
+++ b/src/dfa.c
@@ -1409,10 +1409,10 @@ lex (void)
{
if (syntax_bits & RE_INVALID_INTERVAL_ORD)
goto normal_char;
- dfaerror (_("Invalid content of \\{\\}"));
+ dfaerror (_("invalid content of \\{\\}"));
}
if (RE_DUP_MAX < maxrep)
- dfaerror (_("Regular expression too big"));
+ dfaerror (_("regular expression too big"));
lexptr = p;
lexleft = lim - p;
}
--
1.8.5.5
