On Fri, Nov 21, 2014 at 3:40 PM, Norihiro Tanaka <[email protected]> wrote: > On Fri, 21 Nov 2014 08:40:06 -0800 > Jim Meyering <[email protected]> wrote: >> Once I had installed the locale used by that test and fixed the bug mentioned >> here, I was dismayed to see that the newly-enabled sjis-mb test was >> still failing. >> The attached patch fixes that. > > Thank for the additional fix. Are the removed tests not needed? If they > are needed, I think they should be success with matched, so that at only > a beginning of a pattern grep checks whether an input matches the pattern > at middle in a multi-byte character.
The code covered by the removed tests is still well exercised by the prefix-of-multibyte test, and that test does not depend on a locale that very few people install.
