URL:
<http://savannah.gnu.org/bugs/?52433>
Summary: Commit [09040dbf] is wrong
Project: GNU troff
Submitted by: None
Submitted on: Fri 17 Nov 2017 06:51:01 PM UTC
Category: None
Severity: 3 - Normal
Item Group: None
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Planned Release: None
_______________________________________________________
Details:
I am here for something else, the commit mentioned changed
- if ((*t)->buffer[j] == INLINE_LEADER_CHAR) {
+ if (j < char_block::SIZE && (*t)->buffer[j] == INLINE_LEADER_CHAR) {
where it should have been
+ if (j < (*t)->used && (*t)->buffer[j] == INLINE_LEADER_CHAR) {
instead. But better would be redoing the entire thing, if that
comment is allowed, including indentation fixes. Note especially
that, if all the buffer of *t consumed, and *t stepped to next
buffer, an array index of that _next_ *t with _this_ j is
performed. That cannot be correct?
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?52433>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
bug-groff mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-groff
