URL: <https://savannah.gnu.org/bugs/?59442>
Summary: groff.cpp: correct the order of preprocessors in the pipeline Project: GNU troff Submitted by: bjarniig Submitted on: Tue 10 Nov 2020 05:26:03 PM UTC Category: Core Severity: 3 - Normal Item Group: New feature Status: None Privacy: Public Assigned to: None Open/Closed: Open Discussion Lock: Any Planned Release: None _______________________________________________________ Details: src/roff/groff/groff.cpp: correct the order of preprocessors in the pipeline. The "soelim" command must be the first in the pipeline to incorporate all sourced files into the input file, before it is sent to the next command. Change the order from "preconv, soelim, refer" to "soelim, preconv, refer". As "preconv" can't (currently) figure out the encoding, if it gets its input from standard input, "groff" must be called with the option "-K <encoding>" or "-D <encoding>", and not just with "-k", if the encoding is not the default one. This means that the documentation must then mention this fact in the explanation of the "-s" option. .verbatim+ Signed-off-by: Bjarni Ingi Gislason <bjarn...@rhi.hi.is> --- src/roff/groff/groff.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/roff/groff/groff.cpp b/src/roff/groff/groff.cpp index f568ac02..cd61dbd0 100644 --- a/src/roff/groff/groff.cpp +++ b/src/roff/groff/groff.cpp @@ -53,9 +53,11 @@ extern "C" { // grap, chem, and ideal must come before pic; // tbl must come before eqn -const int PRECONV_INDEX = 0; -const int SOELIM_INDEX = PRECONV_INDEX + 1; -const int REFER_INDEX = SOELIM_INDEX + 1; +// soelim must come first to complete the input file for the later +// commands in the pipeline +const int SOELIM_INDEX = 0; +const int PRECONV_INDEX = SOELIM_INDEX +1; +const int REFER_INDEX = PRECONV_INDEX + 1; const int GRAP_INDEX = REFER_INDEX + 1; const int CHEM_INDEX = GRAP_INDEX + 1; const int IDEAL_INDEX = CHEM_INDEX + 1; -- 2.28.0 _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?59442> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/