Follow-up Comment #9, bug #58962 (project groff):
[comment #8 comment #8:]
> So the patch looks good as-is. One refinement that could maybe be made:
instead of an explicit test for input encoding, maybe define new constants in
src/roff/troff/input.h (which already has separate EBCDIC vs non-EBCDIC
blocks) to compare against. The rest of input.cpp seems to be
encoding-agnostic by using these constants. This also eliminates a run-time
conditional, putting the decision on the compiler.
That's a good idea. By defining constant ints in input.h, I can reduce the
change to input.cpp to just adding 2 more cases to the big switch().
Thanks, Dave!
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?58962>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
