On Friday, 20 June 2025 17:12:50 BST G. Branden Robinson wrote: > Follow-up Comment #20, bug #65098 (group groff): > > [comment #19 comment #19:] > > > Thank you very much for your help, I know I am terrible at ChangeLog, > > Apparently I am too--just look at all the typo fixes I end up committing to > it. :-| > > > all that typing, sorry to put it on you. > > Not a problem. Describing the changes helps force me to understand what you > did and why. > > While I wait for my builds-prior-to-pushing to complete, I have some > comments and questions, mostly matters of small detail. > > First here's the ChangeLog entry; please review it for accuracy. > > > commit ed5c81c8486b5160c52b6198f9a6c0726a5c173c (HEAD -> master) > Author: Deri James <[email protected]> > Date: Fri Jun 20 10:29:22 2025 +0000 > > [devpdf,gropdf]: Support `SS` slanted-symbol font. > > Replace pseudo-slanted characters with a real font, improving typography > of, e.g., slanted lowercase Greek letters as used in eqn(1). > > * font/devpdf/DESC.in: Mount new font `SS` prior to `S`. > > * font/devpdf/SS: New file describes new slanted-symbol font. The > metrics are hand-tweaked. We can't run afmtodit on the symbolsl.afm > file in grops because it produces incorrect metrics]--the width/height > values do not take into account the rescaling of the glyph sizes by .89. > > * font/devpdf/StandardSymSL.pfb: New PostScript font supplies slanted > versions of glyphs in the standard Symbol font. > > * font/devpdf/devpdf.am (GROFF_FONT_FILES): Update macro definition to > scan the build directory for file names matching font descriptions, > excluding both symbol fonts. Relocate definition to be closer to use. > > (devpdffont_DATA): Add new files "SS", "StandardSymSL.pfb", and > "download.in". > > (font/devpdf/SS): New target is generated by copying from source tree > to build tree if they differ. As a side effect, also copy > "StandardSymSL.pfb". > > (font/devpdf/util/BuildFoundries): Copy "download.in" file from source > tree to build tree with new name "download". > > (font/devpdf/download): Set write permission on the target to work > around GNU Automake "distcheck" feature that makes make(1)-generated > files read-only; however we want "BuildFoundries" to rewrite the file > in place.
A while ago you changed it from writing download directly to writing to download.tmp which is then "mv"ed. > (mostlyclean_devpdf_extra): Clean the new files "SS" and > "StandardSymSL.pfb", as well as "S" since the new regex used to > populate the `GROFF_FONT_FILES` now overlooks it. > > (install_devpdf, uninstall_devpdf): Explicitly handle "S" font > description file since the new regex used to populate the > `GROFF_FONT_FILES` now overlooks it. > > * src/devices/gropdf/gropdf.pl: Support multiple specifications of `-F` > option, populating new list `fdlist`. Use the runtime path separator > to populate scalar `fd` if `fdlist` is not a singleton. > > * tmac/pdf.tmac: Drop all 28 calls of `pdf:SS` macro for 24 lowercase > Greek letters and 4 variant forms; the slanted-symbol font now > supplies these. > > Fixes <https://savannah.gnu.org/bugs/?65098>. > > > The stuff is not gating my push; this ticket simply seems like a good place > to discuss some remaining fine details. > > > diff --git a/font/devpdf/DESC.in b/font/devpdf/DESC.in > index 5cb254f37..a5f5b5a71 100644 > --- a/font/devpdf/DESC.in
signature.asc
Description: This is a digitally signed message part.
