Follow-up Comment #19, bug #67509 (group groff):

[comment #17 comment #17:]
> Also the pdf produced after linear search and before this commmit is junk,
> because all the hotspots have man; urls, including the ones which should be
> links to pages in the collection (internal links).

I reckon that's because the derpy syntax error, shown by reading this diff in
reverse...


diff --git a/ChangeLog b/ChangeLog
index 6e8b9389e..3b4b7d8ac 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-03-16  G. Branden Robinson <[email protected]>
+
+       * tmac/pdf.tmac (pdf*href): Fix derpy syntax error, introduced
+       by me in commit cd9fde325f, 4 March.  Exposed by a pending
+       change.
+
 2024-03-16  G. Branden Robinson <[email protected]>
 
        [man]: When formatting PDF, attempt lookups of `MR` destinations
diff --git a/tmac/pdf.tmac b/tmac/pdf.tmac
index 044f19281..6b149637e 100644
--- a/tmac/pdf.tmac
+++ b/tmac/pdf.tmac
@@ -740,7 +740,7 @@ .de pdf*href
 .         \}
 .      el \{\
 .         pdf:lookup \\*[pdf:href-D]
-.         if !'\\*[pdf:lookup-result]'' .ds PDFHREF.DESC
\\*[\\*pdf:lookup-result]
+.         if !'\\*[pdf:lookup-result]'' .ds PDFHREF.DESC
\\*[pdf:lookup-result]
 .         \}
 .      \}
 .   \" Apply border and colour specifications to the PDFMARK string


...prevented the `PDFHREF.DESC` string from being correctly populated; it
instead, I suspect, got an empty value in every case.

However, hmm, the commit _before_ the derp fix seems to be very slow to
produce the book as well.  I'm at 5+ minutes and not even the first warnings:


troff:iconv.1:193: warning: special character 'u0062_0307' not defined
troff:syscall.2:170: warning: cannot select font 'CW'
troff:syscall.2:297: warning: cannot select font 'CW'
troff:newlocale.3:265: warning: special character 'u0061_0304' not defined
troff:newlocale.3:271: warning: special character 'u0075_0304' not defined


...have shown up yet.

(After about 7 minutes, the first did, in fact.  But I think this is going to
be another 35+-minute build.  So I still have some bisection to do today.)


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?67509>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to