Update of bug #50770 (group groff):
Summary: .PSPIC macro at bottom of page causes unwarranted
page break => [PATCH] .PSPIC macro at bottom of page causes unwarranted page
break
_______________________________________________________
Follow-up Comment #22:
The patch below implements the fix Deri described in comment #2.
diff --git a/tmac/pspic.tmac b/tmac/pspic.tmac
index a2b4f922b..b74daa825 100644
--- a/tmac/pspic.tmac
+++ b/tmac/pspic.tmac
@@ -90,7 +90,7 @@
. \}
.
. \" reserve vertical space for image
-. ne (\\n[ps-desht]u + 1v)
+. ne \\n[ps-desht]u
.
. \" compute image offset w.r.t. the current left margin
. if (\\n[ps-offset-mode] == 0) \
A possible commit log (and ChangeLog entry, if this warrants one), summarizing
the history I unearthed in comment #11, is below. Wordsmithing welcome.
Allow .PSPIC macro to place image at bottom of page.
From groff 1.01 through 1.04, the .PSPIC macro did not invoke a break,
explicitly or implicitly; thus the vertical space ".ne"eded for the image was
incremented by 1v to account for a possible partially collected output line.
The ChangeLog.old file shows that James Clark added a break to this macro in a
Mar 16 1992 change (the git history for this era is too coarse to show this
change alone; it first shows up in commit a48ab7b6d, containing all changes
between groff 1.04 and groff 1.05). However, the 1v increment was
(presumably) inadvertently left in place, preventing an image that would
exactly fit at the bottom of a page from being placed there. This adjustment
has been unnecessary for over 34 years, so get rid of it.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?50770>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
