Follow-up Comment #7, bug #68299 (group groff): [comment #6 comment #6:] > Here's the final report, and then it's about ready for me to do Change.log > and commit entries. To test:- > > Apply attached patch to current master. > Note new file "Groff-PDF-Features.ms" in doc/. > > Please report any observations here. > > (file #58602)
Hi Deri,
Texinfo has trouble building groff's Texinfo manual for me with this patch.
$ make -C build -j
make: Entering directory '/home/branden/src/GIT/groff/build'
GEN doc/groff.info
GEN doc/groff.html
doc/groff.texi:4974: warning: node next `ms Page Layout' in menu `Differences
from AT&T ms' and in sectioning `Using PDF features with ms' differ
doc/groff.texi:5274: warning: node `Differences from AT&T ms' is next for
`Using PDF features with ms' in sectioning but not in menu
doc/groff.texi:5274: warning: node `ms Page Layout' is prev for `Using PDF
features with ms' in sectioning but not in menu
doc/groff.texi:5274: warning: node `ms' is up for `Using PDF features with ms'
in sectioning but not in menu
doc/groff.texi:2926: node `ms' lacks menu item for `Using PDF features with
ms' despite being its Up target
doc/groff.texi:5333: warning: node prev `Differences from AT&T ms' in menu `ms
Page Layout' and in sectioning `Using PDF features with ms' differ
make: *** [Makefile:19729: doc/groff.info] Error 1
make: *** Waiting for unfinished jobs....
doc/groff.texi:4974: warning: node next `ms Page Layout' in menu `Differences
from AT&T ms' and in sectioning `Using PDF features with ms' differ
doc/groff.texi:5274: warning: node `Differences from AT&T ms' is next for
`Using PDF features with ms' in sectioning but not in menu
doc/groff.texi:5274: warning: node `ms Page Layout' is prev for `Using PDF
features with ms' in sectioning but not in menu
doc/groff.texi:5274: warning: node `ms' is up for `Using PDF features with ms'
in sectioning but not in menu
doc/groff.texi:2926: node `ms' lacks menu item for `Using PDF features with
ms' despite being its Up target
doc/groff.texi:5333: warning: node prev `Differences from AT&T ms' in menu `ms
Page Layout' and in sectioning `Using PDF features with ms' differ
make: *** [Makefile:19752: doc/groff.html] Error 1
make: Leaving directory '/home/branden/src/GIT/groff/build'
The new PDF docs don't appear in _build/doc_ for me. I see you added them as
targets, so that's weird.
Ah, that seems to be due to _makeinfo_(1) getting angry. Most of our PDF docs
end up in the same target, because they're assigned to the same magical
Automake macro.
_doc/doc.am_:
# $(PROCESSEDDOCFILES_PDF) is omitted because it's unnecessary; the
# Automake macro nodist_docpdfdoc_DATA does what we need.
...
nodist_docpdfdoc_DATA = $(PROCESSEDDOCFILES_PDF)
I'll see if I can sort it out, and if I can I'll submit a patch back to this
ticket.
I see several minor changes and cleanups I'd like to make, but nothing
major--nothing that has to be coupled to your commits.
Also if I make my changes separately and subsequently, they're easier to
revert. ;-)
I didn't cast my vote earlier, so I'll do it now. I think `PDFFEAT` (which
I'd like to rename to `USE_PDF_FEATURES` to make its meaning crystal clear)
default to true (1). Let's show off what we can do! Doing so will help us
catch mistakes if we don't cleanly skip over the PDF stuff in our macro logic
when formatting for non-"pdf" output devices.
Fail early, fail often!
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?68299>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
