From: Christoph Plattner <[EMAIL PROTECTED]>
Subject: Re: Here is the running GRUB DISKLESS stuff
Date: Wed, 05 Apr 2000 09:32:02 +0200
> Sorry, I have not written any entry in the ChangeLog, although
> I normally do. In this case, as I cannot check in directly, I thought
> you inspect the code and so I thought, I should not do entires in
> the ChangeLog, but in future I will.
Generally speaking, you should always write ChangeLog entries,
whether the maintainer applies your patch as is or not.
> But I see, that in the use of such a tag as 'T99' there could be a
> problem in use with DHCP. But see my code as first working step into
> the diskless GRUB operation. Of course there are some steps to
> discuss, but I think it could be a good idea to have the first step
> implemented, if it does not break special design issues - and I don't
> think, this implementation does.
That's right. Your attemption is really good. Let's consider how to
improve it.
> You said, I do not comply with the GNU C style ? Can you give some (or
> one)
> example. The only problem I know is the position of '{' and '}', as
> I have at home our C-style setup of our company. Do you mean this ?
Yes. I don't want to list all of them here, but I show a few. In the
GNU style, an "if" sentence is written like this:
if (foobar)
{
something...
}
but not:
if (foobar)
{
something...
}
A function call is written like this:
foobar (arg1, arg2);
but not:
foobar(arg1, arg2);
Similarly, you must add a space character between a cast and a
value:
(char *) 0
instead of:
(char *)0
Refer to the standards, for the complete information.
Okuji
