From: "Jochen Hoenicke" <[EMAIL PROTECTED]>
Subject: Update of ReiserFS patch.
Date: Wed, 12 Apr 2000 12:13:17 +0200 (MET DST)
> I have updated my ReiserFS patch for grub, to apply more cleanly to
> later CVS versions and to support the new disk format of reiserfs
> introduced in 2.3.xx. It is at
> http://www.informatik.uni-oldenburg.de/~delwi/grub/
Many thanks!
> To Yoshinori: If I can help you by splitting up this patch (e.g. into
> the three parts suggested by the Changelog entries) or by providing a
> diff against my previous patch, don't hesitate to ask me.
No, thank you. I like almost every part of your patches so the size
is not a problem. But if you'd like to help me, please comply with the
ChangeLog rule! For example, the first part is really bad.
2000-04-05 Jochen Hoenicke <[EMAIL PROTECTED]>
* stage2/configure.in: Add reiserfs (version 0-2) support.
stage2/Makefile.am: Likewise.
stage2/disk_io.c (fsys_table): Likewise.
stage2/filesys.h: Likewise.
stage2/builtins.c (setup_func): Likewise.
stage2/shared.h (STAGE2_ID_REISERFS_STAGE1_5): New macro.
stage2/fsys_reiserfs.c: New file.
You must insert a blank line after the first line. When you start a
new file entry, you must prefix it with `*'. You can't write just "Add
foobar support.", because it is too ambiguous. The purpose of
ChangeLog is to track the stream of the development. One day, someone
will want to see when and how to add ReiserFS support and search the
file ChangeLog, then she will find the answer for "when" but not for
"how", unless you write what changed in detail. Bad. Instead, you
should describe what variables and functions are in question, what are
inserted/deleted, what values are used, and so on. I know that writing
ChangeLog entries is not funny, but it is very important.
Okuji
