> As for the netboot stuff, we need to make direct changes on it as
> few as possible.
I understand the issue. However, after checking the latest
"production" and "development" releases, it looks like they both are
pretty different from the code in grub -- at least in the places where
I modified it. My change wouldn't further the two trees any more than
they are separate now. Anyway, it's up to you.
Maybe the best thing to do is remove "-Wshadow", as it generates zillions
of those messages. Three of those warnings, outside of the netboot/ dir, depend
on the curses libs polluting the name space -- a known problem of curses
and its variations.
Thus, I propose this patch, that renmoves -Wshadow. Also, it would be
good to add -Wno-unused and -Wno-pointer-arith in the netboot/ dir,
but I'm not able to do it as I don't (yet) know automake.
standard disclaimer:
feel free to flame if this irrelevant stuff interferes with real work.
Index: configure.in
===================================================================
RCS file: /cvs/grub/configure.in,v
retrieving revision 1.50
diff -u -d -u -r1.50 configure.in
--- configure.in 2000/08/30 07:00:15 1.50
+++ configure.in 2000/09/01 09:36:17
@@ -92,8 +92,9 @@
AC_SUBST(STAGE2_CFLAGS)
AC_SUBST(GRUB_CFLAGS)
-# Enforce coding standards.
-CPPFLAGS="$CPPFLAGS -Wall -Wmissing-prototypes -Wunused -Wshadow"
+# Enforce coding standards (but don't use -Wshadow, as it gives too
+# many false positives, especially in the netboot/ dir.
+CPPFLAGS="$CPPFLAGS -Wall -Wmissing-prototypes -Wunused"
CPPFLAGS="$CPPFLAGS -Wpointer-arith"
AC_CACHE_CHECK([whether -Wundef works], undef_flag, [
