> That change breaks the utility `grub-install'. You need to invent
> another way (e.g. "Error: Selected disk does not exist (21)" is ok).

Hmm... ok. Changing grub-install (appended)?
 
> The extra newline is _not_ wasteful. For example, try this:
> grub> foo [TAB]

I was guessing (without looking at the code) whether libreadline is used.
It looks like it isn't :)  Ok, completion code is too intricate with
conditionals and spare newline outputs to fix it. And we've lost enough
time on this meaningless detail.

Isn't it worth trying to use libreadline (static ;) instead?
This mainly depends on my other question (other message), I think.

--- util/grub-install.orig      Sun Sep  3 07:59:59 2000
+++ util/grub-install   Sun Sep  3 08:01:04 2000
@@ -202,3 +202,3 @@
 EOF
-    if grep "Error: " $log_file >/dev/null; then
+    if grep "Error [0-9]*: " $log_file >/dev/null; then
        cat $log_file 1>&2
@@ -268,3 +268,3 @@
 
-if grep "Error: " $log_file >/dev/null || test $debug = yes; then
+if grep "Error [0-9]*: " $log_file >/dev/null || test $debug = yes; then
     cat $log_file 1>&2

Reply via email to