Follow-up Comment #9, bug #32472 (project grub):

open_device():
If we use fsync() before close(), 

O_SYNC, O_FSYNC should not be used, as it give performance penalty.

When O_SYNC used, every write is blocked  until it goes to disk, and fsync()
does nothing.

When O_SYNC is not used, every write is not blocked, but all modified blocks
are written inside fsync(). During fsync(), blocks may be merged, so not using
O_SYNC may significantly improve performance.

So, see attached patch


(file #23191)
    _______________________________________________________

Additional Item Attachment:

File name: z.patch                        Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32472>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-grub mailing list
Bug-grub@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-grub

Reply via email to