URL: <https://savannah.gnu.org/bugs/?66854>
Summary: search --no-floppy searches floppy
Group: GNU GRUB
Submitter: aklauer
Submitted: Fri 28 Feb 2025 09:19:25 AM UTC
Category: None
Severity: Major
Priority: 5 - Normal
Item Group: None
Status: None
Privacy: Public
Assigned to: None
Originator Name:
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release: Git master
Release:
Reproducibility: None
Planned Release: None
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
Date: Fri 28 Feb 2025 09:19:25 AM UTC By: Andreas Klauer <aklauer>
Transcript:
grub> set debug=disk
grub> search --no-floppy --file filename
[…]
disk: Opening 'fd0'.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: fd0 read failed.
disk: Closing 'fd0'.
commit 68ba54c229 seems to have changed behavior. When commands/search.c ::
iterate_device() encounters fd device and NO_FLOPPY is set, it returns 0 (was
1 before).
However this is executed in context of kern/device.c :: iterate_disk which
then proceeds to iterate_partition ... thus the device is opened and checked
for partition tables, which adds noticable delay (in Qemu which emulates
floppy by default for some reason).
So the goal of skipping the floppy device was not achieved.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?66854>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
