Hi,

Adam Purkrt wrote:
> your patch works fine for me!

So the grub-mkrescue aspects of both alternatives look good so far.

But there is the grub-install aspect to be tested. And that is
absolutely not my realm.
Somebody has to repeatedly run grub-install on a (possibly virtual)
system disk and verify that this system boots each time afterwards and
that no bad things have happened in its /boot/grub tree.

grub-install after the patch is supposed to make backups and to handle
them as it used to do before the patch. Any change in behavior would be
a reason to rework the patch.

If you make such tests with one of the patches then you have it in your
hands which one will look more appealing for submission to grub-devel.
Even better would be if you could talk others into testing.


Have a nice day :)

Thomas


Reply via email to