Hi Konrad, > There's a piece of code I'd like to contribute to your great library. > It consists of a few functions to compute Hermite polynomials, Hermite > functions and their respective derivatives, please see the attachment > gsl_hermite.c.
Thank you! From a quick pass there are a couple of little things: 1) We need a set of gsl_sf_hermite.h declarations. Should this just be all non-static functions declared within your gsl_hermite.c file? Should the single-point functions like gsl_sf_hermite_prob and gsl_sf_hermite_prob_der be publicly exposed too? 2) We need to get the test cases in gsl_hermite_test.c using the GSL test infrastructure. You can see an example of this within specfunc/test_airy.c. I think getting the test code ported over should be relatively quick but I'm uncertain what tolerances to use given the printf statements in your gsl_hermite_test.c code. 3) We'll need to add documentation for the new functions. These will resemble content like doc/specfunc-airy.texi. Much of the necessary content appears in your email and can be written once we've got a gsl_sf_hermite.h in hand from item 1. These three things don't have to happen all in one commit, but we should get them in place before the next release. I must admit I don't know when that is planned. The code looks very nice from a quick browse. Thank you again. - Rhys
