URL:
<http://savannah.gnu.org/bugs/?45521>
Summary: Erroneous use of GSL_ERROR_NULL instead of GSL_ERROR
macro
Project: GNU Scientific Library
Submitted by: psa
Submitted on: Fri 10 Jul 2015 03:33:02 PM GMT
Category: None
Severity: 3 - Normal
Operating System:
Status: None
Assigned to: None
Open/Closed: Open
Release:
Discussion Lock: Any
_______________________________________________________
Details:
from matthias =at= familie =dash= sitte =dot= org
Hi list,
in reference to my previous email I dug through the whole code base, checking
each function that the 'git grep -n -p "GSL_ERROR_NULL"' returned.
Thankfully,
only a couple of more functions turned up which use GSL_ERROR_NULL instead of
GSL_ERROR. Although this might not seem relevant at first, remember that
GSL_SUCCESS equals to 0 as does NULL returned by GSL_ERROR_NULL, so there's
no
way of knowing that those functions might fail if you use a custom error
handler
which doesn't automatically abort.
Anyway, patch attached. If you prefer pull requests instead, let me know.
Cheers,
Matthias
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Fri 10 Jul 2015 03:33:02 PM GMT Name:
fix_erroneous_use_of_gsl_error_null_macro.patch Size: 7kB By: psa
<http://savannah.gnu.org/bugs/download.php?file_id=34413>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?45521>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
