Follow-up Comment #1, bug #66800 (group gsl): I have a couple of issues with this PR.
First: I don't understand where this variable `i` comes from. It's not defined
in the scope of the function and seems to replace `k` in most but not all
cases. Is this a copy-paste error?
Similarly, is there a particular reason that you replaced log1p with
gsl_log1p? Both functions exist in the scope but we use simply `log1p` in
binomial.c and in the previous version of this file. However I'm not familiar
enough with this project to know if one is preferred over the other.
Second: If we're going to add edge-case checking analogous to binomial.c, then
let's finish the job and add the case where p==0 as well. I've attached a file
with an updated diff with my suggestions.
(file #56912)
_______________________________________________________
Additional Item Attachment:
File name: nbinomial-2.diff Size: 642B
<https://file.savannah.gnu.org/file/nbinomial-2.diff?file_id=56912>
AGPL NOTICE
These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-513955078e56c124c506c834d031bbe09cbf4040.tar.gz
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?66800>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
