Am Montag, 25. Februar 2013 schrieb Mark H Weaver: > Andreas Enge <[email protected]> writes: > > (has-env (string-suffix? "/env" interp)) > > I think we might want to make this test more restrictive. I'm looking > at a package (guile-figl) that includes an 'env' script in its build > directory, analogous to 'pre-inst-env' in Guix. This makes me worry > that the test above will have false positives. > > In practice, the path used is (almost?) always "/usr/bin/env". > I suspect it would be safer to check for that exact string.
I also wondered whether we should do this. Do you have a concrete example where the current test fails? Notice that the suffix is only part of the test; currently, we patch files that start with [[:blank:]]*#![[:graph:]]*/env Unless a problem manifests itself, I would not change that behaviour. Andreas
