Hi, Efraim Flashner <efr...@flashner.co.il> skribis:
> On Fri, Nov 09, 2018 at 12:11:34AM +0100, Björn Höfling wrote: [...] >> One of my review-tasks is this: >> >> [] Binaries included? If yes, created a snipped? >> find . -name "*.rar" -or -name "*.pdf" -or -name "*.bin" -or -name >> "*.pdf" -or -name "*.dsy" -or -name "*.jar" -or -name "*.exe" > > also "*.so" or "*.a" I assume. > > For python we'd want to grep the source files for "Generated by Cython" Indeed. The “risk”, if we make the list too long, is that we’ll find that we’re not doing so well in many cases. We should make sure we can address all these issues. >> Should this be a phase of the build system? Or just a linter, that was >> my first idea? > > I'd go with a phase Same here. It’d be inconvenient to implement in ‘guix lint’ because we’d first need to extract the tarball etc. Thanks, Ludo’.
