On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote: > 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of > a package, not propagated-inputs.
The attached patch should add the propagated inputs to the list of inputs to check. Do we want to start telling it to ignore some of them? gnu/packages/check.scm:2200:2: [email protected]: 'python-nose' should probably be a native input -- Efraim Flashner <[email protected]> אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted
From 2ca0a385847c8dfcaffe4f32c5dbce7297086859 Mon Sep 17 00:00:00 2001 From: Efraim Flashner <[email protected]> Date: Fri, 10 Apr 2020 00:29:56 +0300 Subject: [PATCH] lint: Check for inappropriate inputs in propagated-inputs too. * guix/lint.scm (check-inputs-should-be-native): Also check the propagated inputs of the package. --- guix/lint.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index 72582cfffb..bda5c0cd77 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -7,7 +7,7 @@ ;;; Copyright © 2016 Hartmut Goebel <[email protected]> ;;; Copyright © 2017 Alex Kost <[email protected]> ;;; Copyright © 2017 Tobias Geerinckx-Rice <[email protected]> -;;; Copyright © 2017, 2018 Efraim Flashner <[email protected]> +;;; Copyright © 2017, 2018, 2020 Efraim Flashner <[email protected]> ;;; Copyright © 2018, 2019 Arun Isaac <[email protected]> ;;; ;;; This file is part of GNU Guix. @@ -286,7 +286,8 @@ of a package, and INPUT-NAMES, a list of package specifications such as (define (check-inputs-should-be-native package) ;; Emit a warning if some inputs of PACKAGE are likely to belong to its ;; native inputs. - (let ((inputs (package-inputs package)) + (let ((inputs (append (package-inputs package) + (package-propagated-inputs package))) (input-names '("pkg-config" "autoconf" -- 2.26.0
signature.asc
Description: PGP signature
