Hi terramorpha, your patch is missing the ChangeLog part of the commit message, see `info '(guix)Submitting Patches'` for more information.
Am Samstag, den 10.07.2021, 15:31 -0400 schrieb terramor...@cock.li: > diff --git a/gnu/packages/networking.scm > b/gnu/packages/networking.scm > index 19b58501e9..af3082b954 100644 > --- a/gnu/packages/networking.scm > +++ b/gnu/packages/networking.scm > @@ -4100,3 +4100,37 @@ on hub/switched networks. It is based on > @acronym{ARP} packets, it will send > @acronym{ARP} requests and sniff for replies.") > (home-page "https://github.com/netdiscover-scanner/netdiscover") > (license license:gpl3+))) > + > +(define-public putty > + (package > + (name "putty") > + (version "0.74.0") > + (source (origin > + ;; (method url-fetch) > + (method url-fetch) > + (uri "http://www.putty.be/0.74/putty-0.74.tar.gz") You ought to reuse version here, so that people don't need to rewrite it when the version changes. You can use "version-major+minor" to access the "0.74" part, but I assume this is one of the versions, that gets patch added to the tarball if it exists. Such packages too exist somewhere in Guix, but I haven't found an example in the quick time I'm typing this reply. > + (sha256 (base32 > "0zc43g8ycyf712cdrja4k8ih5s3agw1k0nq0jkifdn8xwn4d7mfx")))) Please watch your line length, it normally shouldn't exceed 80 characters. > + (arguments > + `(#:tests? > + #f Never let #tests? #f stay uncommented. > + #:phases (modify-phases %standard-phases > + (add-before 'configure 'go-into-unix/ > + (lambda _ (begin > + (chdir "unix") > + #t)))))) > + (build-system gnu-build-system) > + (inputs `(("perl" ,perl) > + ("python" ,python) > + ("python2" ,python-2.7) > + ("pkg-config" ,pkg-config) > + ("gtk+" ,gtk+))) Your formatting generally looks a bit off. #:phases should go to an extra line, as should inputs. #:tests? #f OTOH is okay in one line with the aforementioned comment. > + (synopsis "A graphical @acronym{SSH} and telnet client") > + (description > + "Putty is a powerful terminal client. It supports > @acronym{SSH}, > telnet, > +and raw socket connections with good terminal emulation. It > supports > public > +key authentication and Kerberos single-sign-on. It also includes > command-line > +@acronym{SFTP} and @acronym{SCP} implementations.") > + (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/" > ) > + (license (license:non-copyleft > + > "https://www.chiark.greenend.org.uk/~sgtatham/putty/licence.html" > + "The putty license")))) Putty claims, that this is license:expat and it does look like one. Regards, Leo