Hi! Kyle Meyer <k...@kyleam.com> skribis:
> Ludovic Courtès writes: > >> For the record, I tried the attached patch in an attempt to sort things >> as discussed in the issue above, but it doesn’t have the intended >> effect. There must be other unsorted dictionaries elsewhere. > > Hmm, I don't think dictionaries are a likely culprit here because > Python's dict implementation preserves the insertion order as of Python > v3.6 (and that behavior is declared as part of the language spec with > v3.7). Ah, silly me. > In cases where the order of the keys isn't specified (i.e. Python 3.5 > and below), I think the end result after your change is the same: it > creates a new dictionary for sorted _input_, but things won't > necessarily come out in the same order. Noted, thanks for explaining. > I'm not familiar with PeachPy, but taking a peek at name.py, the sets > used for the values of the prenames dictionary could be the problem. > And if that's the case, one solution would be switching those values > from sets to dictionaries. > > With the change below (on top of PeachPy's 257881e), nnpack builds > reliably for me across a couple of attempts: > > $ guix-dev build --with-git-url=python-peachpy=$local --no-grafts --check > nnpack > successfully built > /gnu/store/7z4nl55gssrf9na7wsvmw1dsqgawnj2p-nnpack-0.0-1.c07e3a0.drv > successfully built > /gnu/store/7z4nl55gssrf9na7wsvmw1dsqgawnj2p-nnpack-0.0-1.c07e3a0.drv > /gnu/store/4ihjil42fbk53q73gpvdakynbv9q5q09-nnpack-0.0-1.c07e3a0 Your patch does the trick, indeed. I went ahead and pushed it as b87fe805aa66851f17f56078cb0e94f7cc4525df. Thank you! Ludo’.
