Hi, Am Dienstag, den 16.11.2021, 19:48 +0000 schrieb Vivien Kraus: > > > + (emacs-substitute-sexps "vala-mode.el" > > > + (";; Support multiline strings" 'disabled.) > > > + ("(defcustom vala-multiline-strings nil" > > > + "This variable is ignored."))))))) > > This inserts mostly bogus into the file rather than killing the > > sexps > > as it should. > > The first substitution fully kills the whole sexp (and inserts a > comment that reads "Support for multiline strings disabled." if you > don’t read too closely ^^). That was too sneaky for me :P
> It’s true that the second does not kill the defcustom expansion, but > since it’s part of the intended public API, I’m not so sure we should > remove it altogether. I think it’s clearer for the user that way, > because the two modifications are kind of documented in the source. > > Also, it’s shorter. I'm pretty sure you can still use vala-multiline-strings inside a custom-set-variables form, it will just do nothing as it ought to. > Anyway, Here are the two versions, you decide. I rewrote your batch-edit version to be a little clearer and to leave documented FIXMEs in the code. I pushed the rewrite, so you should now be able to use emacs-vala-mode, with or without lsp. Cheers