I opened a pull request upstream that just removes the specific test for 
“HEAD@{10 years ago}". Since that functionality is well-covered by subsequent 
tests.

See here for the PR: https://github.com/libgit2/libgit2/pull/6299 
<https://github.com/libgit2/libgit2/pull/6299>

> Though maybe by that time, we have complete time namespaces …
One would hope!

Cheers,
Carl Dong

> On May 9, 2022, at 3:25 AM, Maxime Devos <maximede...@telenet.be> wrote:
> 
> Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
>> Fixed:
>> 
>>   e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>>   f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
> 
> It's still time-dependent though:
> 
>> +                  (substitute* "tests/refs/revparse.c"
>> +                    (("10 years ago")
>> +                     "100 years ago"))))))
> 
> wouldn't it now fail after ~100 or ~1000 years?
> Though maybe by that time, we have complete time namespaces ...
> 
> Greetings,
> Maxime.

Attachment: signature.asc
Description: Message signed with OpenPGP

Reply via email to