Hi Kaelyn,

Kaelyn via Bug reports for GNU Guix 写道:
Here is a revised diff with comments added for the flags.

Thanks again! Pushed as 536adbd7cca1f257261645d9cfd7910a0055a60e, also with a commit message added.

+ ;; Enable building with LTO to avoid linker errors about
+         ;; non-virtual thunks on i686-linux.
+         "--enable-lto"
+ ;; Disable galleries to avoid errors rebuilding the Gtk icon
+         ;; cache, at least on i686-linux.
+         "--without-galleries"

The importance of comments is to document the ‘why’. The ‘what’ is obvious from the flags themselves, so I removed the first few words of each comment to make them fit nicely on 1 line.

Kind regards,

T G-R

Attachment: signature.asc
Description: PGP signature

Reply via email to