Hello, Sergiu Ivanov <sergiu.iva...@univ-evry.fr> writes:
> Hi again, > > Maxim Cournoyer <maxim.courno...@gmail.com> [2023-01-16T18:01:59+0100]: >> >> Don't forget to CC my email when sending a revised v2 version with the >> above :-). > > I CCed you, but Google doesn't like another quirk in my E-mail > configuration which I don't have motivation to debug :-S > > I therefore sending you a small ping from my work E-mail, and I'm > attaching the 3 updated patches just in case it is more convenient > for you. Thanks! I've made cosmetic adjustments to the update commit like so: --8<---------------cut here---------------start------------->8--- modified gnu/packages/gtk.scm @@ -2968,12 +2968,17 @@ (define-public volctl (lambda* (#:key inputs #:allow-other-keys) (substitute* "volctl/xwrappers.py" (("libXfixes.so") - (string-append (search-input-file inputs "/lib/libXfixes.so"))))))))) + (string-append (search-input-file inputs + "/lib/libXfixes.so"))))))))) (inputs (list libxfixes)) (propagated-inputs - (list python-click python-pycairo python-pygobject python-pyyaml - python-pulsectl gtk+)) + (list python-click + python-pycairo + python-pygobject + python-pyyaml + python-pulsectl + gtk+)) (home-page "https://buzz.github.io/volctl/") (synopsis "Per-application volume control and on-screen display") (description "Volctl is a PulseAudio-enabled tray icon volume control and --8<---------------cut here---------------end--------------->8--- added a proper GNU Change Log to the commit message: --8<---------------cut here---------------start------------->8--- gnu: volctl: Update to 0.9.3. Fixes <https://issues.guix.gnu.org/58120>. * gnu/packages/gtk.scm (volctl): Update to 0.9.3. [arguments]: Update substitutions in patch-path phase and delete trailing #t. [inputs]: Delete pulseaudio. Move gtk+ to... [propagated-inputs] ... here. --8<---------------cut here---------------end--------------->8--- and pushed the series! Notice that in my environment, it doesn't run: --8<---------------cut here---------------start------------->8--- $ volctl PulseAudio connected Warning: Could not embed Gtk.StatusIcon. Fatal error: Could not create a status icon. Are you sure you have a working notification area? pulseaudio disconnected Alarm clock --8<---------------cut here---------------end--------------->8--- although I have 'dunst' running on top of my ratpoison WM. -- Thanks, Maxim