Hi Ludo’,

On 2023-07-12 21:52, Ludovic Courtès wrote:
> Hi,
> 
> Bruno Victal <mi...@makinata.eu> skribis:
> 
>> Although 'register-services' is exported its counterpart
>> 'deregister-service' is not.
>>
>> Some notes:
>> * 'register-services' is in its plural form while its counterpart
>> is not, maybe one of them should be renamed for consistency sake?
>>
>> * From the docstring and code the interface of 'deregister-service'
>> seems to differ from 'register-services' though I haven't
>> confirmed it. Perhaps add some documented examples for reference?
> 
> All good points.  Since ‘deregister-service’ is an internal helper with
> a clunky interface (it takes a string, special-cases "all", prints
> messages), I propose exposing ‘unregister-services’ as defined below.
> 
> WDYT?

Neat, LGTM.


-- 
Furthermore, I consider that nonfree software must be eradicated.

Cheers,
Bruno.



Reply via email to