,---- "Alfred M. Szmidt" <[EMAIL PROTECTED]> writes:
| You might also want to note that this was reported by Richard Smith.
`----
Sure we should do that. And thanks for correcting me that bug was not
fixed in the CVS.
Here is the updated ChangeLog.
file: libdiskfs/ChangeLog
======================================================================
2002-12-09 M.P. Anand Babu <[EMAIL PROTECTED]>
* dir-renamed.c (diskfs_rename_dir): check if fromcred->user
has enough permissions to unlink node fnp from its parent fdp
before moving. Bug reported by Richard Smith <[EMAIL PROTECTED]>
======================================================================
Patch dir-rename-parentdir-perm-bug
======================================================================
diff -pruN hurd/libdiskfs/dir-renamed.c hurd-ab/libdiskfs/dir-renamed.c
--- hurd/libdiskfs/dir-renamed.c 2001-10-11 19:49:17.000000000 -0700
+++ hurd-ab/libdiskfs/dir-renamed.c 2002-12-08 23:54:17.000000000 -0800
@@ -91,6 +91,11 @@ diskfs_rename_dir (struct node *fdp, str
if (fdp != tdp)
mutex_lock (&tdp->lock);
+ /* Check if we are allowed to modify "ftp" with respect to "fnp" */
+ err = fshelp_checkdirmod (&fdp->dn_stat, &fnp->dn_stat, fromcred->user);
+ if (err)
+ goto out;
+
/* 1: Lookup target; if it exists, make sure it's an empty directory. */
ds = buf;
err = diskfs_lookup (tdp, toname, RENAME, &tnp, ds, tocred);
======================================================================
--
_.|_
(_||_)
Free as in Freedom <www.gnu.org>
_______________________________________________
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd
