"Alfred M. Szmidt" <[EMAIL PROTECTED]> writes:
> Just some minor nit-picks. Overall the patch looks ok.
>
> @@ -62,6 +62,9 @@ static char *vga_display_font_bold;
> "/lib/hurd/fonts/vga-system-bold-italic.bdf"
> static char *vga_display_font_bold_italic;
>
> +/* Use all colors when set, otherwise use double font slots. */
> +static int vga_display_full_color = 0;
> +
>
> I would prefer to have the comment for VGA_DISPLAY_FULL_COLOR to be:
>
> If zero use all colors, else use double font slots.
Ok, I agree. I will make this change.
> Less thinking about what "set" means.
>
> @@ -171,12 +174,23 @@ parse_startup_args (int no_exit, int arg
> } \
> } while (0)
>
> +#define PARSE_FONT_OPT_NOARGS(x,y,z) \
> + { \
> + if (!strcmp (argv[*next], x)) \
> + { \
> + printf("foo\b"); \
>
> Left from debugging?
No, what makes you think this?
Thanks,
Marco
_______________________________________________
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd
