> Are you sure that changing the #ifdef to #if is the right > change? > > Quite, if you have specific concerns that I might have missed > then please speak up.
Your patch is potentially a functional change; not simply a bug fix. You've defended the addition of CONFIG_BSD_DISKLABEL but not the change from #ifdef to #if. If you have specific concerns around it, please state them. You have not done so. If you prefer `#if defined (foo) && defined (bar)', that is fine too. _______________________________________________ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.gnu.org/mailman/listinfo/bug-hurd